fix batch bug #504
Merged
fix batch bug #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
BeachWang
commented
Dec 2, 2024
•
BeachWang
commented
- 修改Turbo和batch操作的判断逻辑
- Turbo加速逻辑：对batch算子不起作用，非batch算子时turbo等于True不会打batch，速度快，等于false时打成batch size等于1的batch sample，速度慢。
- 原先逻辑turbo等于false时，非batch算子的batch size可能不等于1，导致sample丢失。
- 将filter和map对参数相同的操作挪到一个函数里，以免出现一个地方修改另外一个地方遗漏的情况。目前turbo逻辑filter和map保持一致了。
- 限定pyav版本。
BeachWang
requested review from
HYLcool,
pan-x-c,
garyzhang99,
yxdyc and
Cathy0908
BeachWang
added a commit
that referenced
this pull request
Dec 5, 2024
* init python_lambda_mapper * set default arg * fix init * support batched & add docs * fix docs * Quick fix for some minor problems (#503) * * remove str conversion for fps para of add_stream func + add requires from librosa to avoid lazy_loader failure during multiprocessing * * remove str conversion for fps para of add_stream func + add requires from librosa to avoid lazy_loader failure during multiprocessing * * install cmake before * * install cmake before * * install cmake before * * update unit test tags * * update unit test tags * * update unit test tags * * update unit test tags * * try to remove samplerate dep * * skip audio duration and audio nmf snr filters * * skip video_tagging_from_frames_filter * * skip video_tagging_from_audios_filter * * skip video_motion_score_raft_filter * fix batch bug (#504) * fix batch bug * fix filter batch * not rank for filter * limit pyav version --------- Co-authored-by: Yilun Huang <[email protected]> Co-authored-by: BeachWang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.