Skip to content

Conversation

@akaihaoshuai
Copy link

add cmmlu and gsm8k

Signed-off-by: 子悬 <[email protected]>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @akaihaoshuai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the system's data processing capabilities by introducing two new datasets, Cmmlu and Gsm8k. These additions broaden the range of benchmarks available for evaluating model performance, particularly in areas like multi-level language understanding and mathematical reasoning. The changes also include a minor optimization to an existing dataset download method.

Highlights

  • New Dataset Support: Added support for the Cmmlu dataset, enabling performance evaluation on Chinese multi-level language understanding tasks.
  • New Dataset Support: Integrated the Gsm8k dataset, allowing for evaluation on grade school math word problems.
  • Dataset Plugin Imports: Updated the main dataset plugin initialization file to include the newly added Cmmlu and Gsm8k dataset plugins.
  • Dataset Download Optimization: Refined the dataset download process for the OpenQA dataset by removing an unnecessary 'allow_patterns' argument, simplifying the download of the entire dataset snapshot.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for cmmlu and gsm8k datasets. The implementation for the new dataset plugins is a good start, but there are a few areas for improvement. I've found some issues related to type safety, consistency with other plugins, and a potential performance regression in an existing plugin. My comments below provide specific suggestions for each of these points.

fix
Signed-off-by: 子悬 <[email protected]>
@Yunnglin
Copy link
Collaborator

Yunnglin commented Sep 4, 2025

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the cmmlu and gsm8k datasets. The implementation is mostly correct, but I've found a critical issue in both new dataset plugins related to a type mismatch in the build_messages method, which could lead to runtime errors. I have provided suggestions to fix this and simplify the code. Additionally, I've included several comments on style and consistency to improve code quality and maintainability, such as sorting imports, removing extraneous whitespace, and using consistent language for comments.

@Yunnglin
Copy link
Collaborator

Yunnglin commented Sep 5, 2025

Thank you for your PR! There are a few minor issues that need to be fixed:

  1. Run the following commands to fix lint issues:

    pip install pre-commit
    pre-commit install
    pre-commit run --all-files
  2. Change yield [prompt] to yield prompt

  3. I couldn't find the haonan-li/cmmlu dataset on ModelScope. Is there an issue with the data source?

子悬 added 3 commits September 5, 2025 11:07
Signed-off-by: 子悬 <[email protected]>
Signed-off-by: 子悬 <[email protected]>
Signed-off-by: 子悬 <[email protected]>
@akaihaoshuai
Copy link
Author

fixed

@Yunnglin
Copy link
Collaborator

Yunnglin commented Sep 5, 2025

please change yield [message] to

if self.query_parameters.apply_chat_template:
    message = self.create_message(prompt)
    yield [message]
else:
    yield prompt

in gsm8k and openqa

@akaihaoshuai akaihaoshuai closed this by deleting the head repository Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants