Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(utils): intersection 내부구현 수정 완료 #266

Merged
merged 3 commits into from
Jun 26, 2024

Conversation

Sangminnn
Copy link
Collaborator

@Sangminnn Sangminnn commented Jun 26, 2024

Overview

Issue: #265

별도의 함수를 두어 계산하던 중복제거 intersection을 가독성을 위해 intersectionWithDuplicates와 uniq 함수의 조합으로 변경하였습니다.

내부구현만 변경하였기에 테스트코드와 문서에는 수정사항이 없습니다.

PR Checklist

  • All tests pass.
  • All type checks pass.
  • I have read the Contributing Guide document.
    Contributing Guide

@Sangminnn Sangminnn requested a review from ssi02014 as a code owner June 26, 2024 14:11
Copy link

changeset-bot bot commented Jun 26, 2024

🦋 Changeset detected

Latest commit: 7138f48

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@modern-kit/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@ssi02014 ssi02014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작업감사합니다 :)

@ssi02014 ssi02014 merged commit 4ac36fa into modern-agile-team:main Jun 26, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Jun 26, 2024
@Sangminnn Sangminnn deleted the chore/intersection branch June 26, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants