Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react): SeparatedIterator 신규 컴포넌트 추가 #274

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

ssi02014
Copy link
Contributor

@ssi02014 ssi02014 commented Jun 28, 2024

Overview

Issue: #269

Iterator를 확장해 items props로 주어진 배열을 반복하면서 각 항목에 대해 특정 요소 및 컴포넌트를 렌더링하며, 동시에 각 요소 사이에 Separator를 렌더링 하는 컴포넌트입니다.

기본적으로 마지막 요소 다음 Separator는 제외됩니다. includeLastSeparatortrue로 설정해서 포함시킬 수 있습니다.

<SeparatedIterator
  items={items}
  renderItem={(item) => <h3>{item}</h3>}
  separator={<Divider />}
/>

PR Checklist

  • All tests pass.
  • All type checks pass.
  • I have read the Contributing Guide document.
    Contributing Guide

@ssi02014 ssi02014 added feature 새로운 기능 추가 @modern-kit/react @modern-kit/react labels Jun 28, 2024
@ssi02014 ssi02014 requested a review from Sangminnn June 28, 2024 10:14
@ssi02014 ssi02014 self-assigned this Jun 28, 2024
Copy link

changeset-bot bot commented Jun 28, 2024

🦋 Changeset detected

Latest commit: 3e3f1ec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@modern-kit/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.84%. Comparing base (58d7750) to head (3e3f1ec).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
+ Coverage   96.83%   96.84%   +0.01%     
==========================================
  Files         116      117       +1     
  Lines        1231     1237       +6     
  Branches      303      305       +2     
==========================================
+ Hits         1192     1198       +6     
  Misses         33       33              
  Partials        6        6              
Components Coverage Δ
@modern-kit/react 94.42% <100.00%> (+0.04%) ⬆️
@modern-kit/utils 100.00% <ø> (ø)

@ssi02014 ssi02014 merged commit 08e4eaf into main Jun 28, 2024
3 checks passed
@ssi02014 ssi02014 deleted the feat/SeparatedIterator branch June 28, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 새로운 기능 추가 @modern-kit/react @modern-kit/react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant