Qodana

fix(Flax.cs): Makes flax flippable and fixes stacking #65

Triggered via pull request July 19, 2024 20:58

Mink80

opened #1874

Mink80/FixFlaxStacking

Status Success

Total duration 12m 51s

Artifacts –

code_quality.yml

on: pull_request

qodana

12m 39s

Annotations

23 warnings and 154 notices

Expression is always 'true' or always 'false': Projects/Server/MultiData.cs#L122

Expression is always true

Replace 'switch' statement with 'switch' expression: Projects/UOContent/Misc/Gifts/Winter2004/LightOfTheWinterSolstice.cs#L75

Convert 'switch' statement to 'switch' expression

Replace 'switch' statement with 'switch' expression: Projects/UOContent/Engines/Factions/Items/Traps/FactionTrapRemovalKit.cs#L56

Convert 'switch' statement to 'switch' expression

Expression is always 'null': Projects/UOContent/Commands/Dupe.cs#L101

Expression is always null

Heuristically unreachable code: Projects/Server/Serialization/ISerializable.cs#L66

Code is heuristically unreachable

Heuristically unreachable code: Projects/Server/Serialization/ISerializable.cs#L42

Code is heuristically unreachable

Incorrect indent (missing indent/outdent elsewhere): Projects/UOContent/Spells/Necromancy/VengefulSpirit.cs#L60

Unexpected line indent change

Return value of [MustUseReturnValue] annotated method is not used: Projects/Server/World/EntityPersistence.cs#L227

Return value of method is not used. Fewer bytes can be read than requested

Return value of [MustUseReturnValue] annotated method is not used: Projects/Server/Serialization/BinaryFileReader.cs#L67

Return value of method is not used. Fewer bytes can be read than requested

Non-accessed field (private accessibility): Projects/UOContent/Misc/Gifts/Winter2004/SnowPile.cs#L79

Field 'm_Thrower' is assigned but its value is never used

Non-accessed field (private accessibility): Projects/UOContent/Misc/Gifts/Winter2004/PileOfGlacialSnow.cs#L94

Field 'm_Snow' is assigned but its value is never used

Non-accessed field (private accessibility): Projects/UOContent/Misc/Gifts/Winter2004/SnowPile.cs#L78

Field 'm_Snow' is assigned but its value is never used

Non-accessed field (private accessibility): Projects/UOContent/Misc/Gifts/Winter2004/PileOfGlacialSnow.cs#L95

Field 'm_Thrower' is assigned but its value is never used

Type member is never used (private accessibility): Projects/UOContent/Spells/Seventh/EnergyField.cs#L112

Constructor 'InternalItem' is never used

Type member is never used (private accessibility): Projects/UOContent/Spells/Third/WallOfStone.cs#L103

Constructor 'InternalItem' is never used

Type member is never used (private accessibility): Projects/UOContent/Items/Weapons/Axes/BaseAxe.cs#L108

Method 'Deserialize' is never used

Unused nullable directive: Projects/Server/Main.cs#L48

Unused nullable directive

Unused parameter (private accessibility): Projects/UOContent/Items/Weapons/Axes/BaseAxe.cs#L108

Parameter 'reader' is never used

Unused parameter (private accessibility): Projects/UOContent/Items/Weapons/Axes/BaseAxe.cs#L108

Parameter 'version' is never used

Unused parameter (private accessibility): Projects/UOContent/Holiday Stuff/Halloween/2006/Items/HalloweenPumpkin.cs#L82

Parameter 'reader' is never used

Incorrect indent (incorrect indent size): Projects/UOContent/Items/Weapons/Abilities/WeaponAbility.cs#L269

Indent size is incorrect, expected outdent 2 spaces

Incorrect indent (incorrect indent size): Projects/UOContent/Spells/Necromancy/VengefulSpirit.cs#L54

Indent size is incorrect, expected indent 8 spaces

qodana

The following actions uses Node.js version which is deprecated and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Namespace does not correspond to file location: Projects/Server/World/EntityTypeIndex.cs#L16

Namespace does not correspond to file location, must be: 'Server.World'

Namespace does not correspond to file location: Projects/UOContent/Misc/Gifts/Winter2004/DecorativeTopiary.cs#L1

Namespace does not correspond to file location, must be: 'Server.Misc.Gifts.Winter2004'

Namespace does not correspond to file location: Projects/UOContent/Misc/Gifts/Winter2004/SnowPile.cs#L5

Namespace does not correspond to file location, must be: 'Server.Misc.Gifts.Winter2004'

Namespace does not correspond to file location: Projects/Server/Serialization/BinaryFileReader.cs#L25

Namespace does not correspond to file location, must be: 'Server.Serialization'

Namespace does not correspond to file location: Projects/UOContent/Misc/Gifts/Winter2004/LightOfTheWinterSolstice.cs#L1

Namespace does not correspond to file location, must be: 'Server.Misc.Gifts.Winter2004'

Namespace does not correspond to file location: Projects/Server/World/EntityPersistence.cs#L23

Namespace does not correspond to file location, must be: 'Server.World'

Namespace does not correspond to file location: Projects/UOContent/Misc/Gifts/Winter2004/Winter2004.cs#L4

Namespace does not correspond to file location, must be: 'Server.Misc.Gifts.Winter2004'

Namespace does not correspond to file location: Projects/UOContent/Engines/Ethics/Core/Persistance.cs#L1

Namespace does not correspond to file location, must be: 'Server.Engines.Ethics.Core'

Namespace does not correspond to file location: Projects/Server/World/IIndexInfo.cs#L16

Namespace does not correspond to file location, must be: 'Server.World'

Namespace does not correspond to file location: Projects/UOContent/Misc/Gifts/Winter2004/SnowyTree.cs#L1

Namespace does not correspond to file location, must be: 'Server.Misc.Gifts.Winter2004'

Namespace does not correspond to file location: Projects/UOContent/Misc/Gifts/Winter2004/FestiveCactus.cs#L1

Namespace does not correspond to file location, must be: 'Server.Misc.Gifts.Winter2004'

Namespace does not correspond to file location: Projects/Server/Serialization/BinaryFileWriter.cs#L20

Namespace does not correspond to file location, must be: 'Server.Serialization'

Namespace does not correspond to file location: Projects/UOContent/Misc/Gifts/Winter2004/PileOfGlacialSnow.cs#L5

Namespace does not correspond to file location, must be: 'Server.Misc.Gifts.Winter2004'

Namespace does not correspond to file location: Projects/UOContent/Misc/Gifts/Winter2004/Mistletoe.cs#L6

Namespace does not correspond to file location, must be: 'Server.Misc.Gifts.Winter2004'

Unused local variable: Projects/UOContent/Engines/Factions/Mobiles/Guards/Types/FactionBerserker.cs#L69