Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(triangle): raise if output files not found #1954

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Sep 19, 2023

  • previously Triangle.build() would continue silently if expected output files not found after invoking exe
  • raise FileNotFoundError immediately instead
  • remove unneeded return statements
  • motivation

@wpbonelli wpbonelli marked this pull request as ready for review September 19, 2023 04:23
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #1954 (6cf1c5b) into develop (9e9d730) will decrease coverage by 0.7%.
Report is 1 commits behind head on develop.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           develop   #1954     +/-   ##
=========================================
- Coverage     72.6%   72.0%   -0.7%     
=========================================
  Files          257     257             
  Lines        57812   57653    -159     
=========================================
- Hits         42009   41537    -472     
- Misses       15803   16116    +313     
Files Changed Coverage Δ
flopy/utils/triangle.py 65.7% <100.0%> (-0.2%) ⬇️

... and 72 files with indirect coverage changes

@wpbonelli wpbonelli merged commit 9ca6012 into modflowpy:develop Sep 22, 2023
13 of 21 checks passed
@wpbonelli wpbonelli deleted the triangle branch September 22, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant