Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use_pandas=False in mf6 sim/pkgs until regressions fixed #1979

Closed
wants to merge 1 commit into from

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Oct 5, 2023

  • avoid test failures with use_pandas=True
    • mf6: test_gwf_disu.py, test_gwf_errors.py::test_disu_errors
    • flopy: test_binaryfile.py::test_read_mf6_2sp
  • regenerate mf6 pkg classes from mf6 develop
  • run formatter in notebooks/autotests
  • supersedes fix: regenerate classes from mf6 develop #1978

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1979 (061d4b8) into develop (1eddf86) will decrease coverage by 1.0%.
Report is 1 commits behind head on develop.
The diff coverage is 23.4%.

@@            Coverage Diff            @@
##           develop   #1979     +/-   ##
=========================================
- Coverage     72.7%   71.8%   -1.0%     
=========================================
  Files          257     258      +1     
  Lines        57809   58808    +999     
=========================================
+ Hits         42074   42241    +167     
- Misses       15735   16567    +832     
Files Coverage Δ
flopy/mf6/data/mfdata.py 75.8% <100.0%> (+0.1%) ⬆️
flopy/mf6/data/mfdataarray.py 60.9% <ø> (-0.1%) ⬇️
flopy/mf6/data/mfdatalist.py 71.0% <100.0%> (-0.4%) ⬇️
flopy/mf6/data/mfdatascalar.py 60.5% <ø> (-0.2%) ⬇️
flopy/mf6/mfsimbase.py 67.5% <100.0%> (+<0.1%) ⬆️
flopy/mf6/modflow/mfgwfchd.py 100.0% <100.0%> (ø)
flopy/mf6/modflow/mfgwfdrn.py 100.0% <100.0%> (ø)
flopy/mf6/modflow/mfgwfevt.py 100.0% <ø> (ø)
flopy/mf6/modflow/mfgwfevta.py 100.0% <100.0%> (ø)
flopy/mf6/modflow/mfgwfghb.py 100.0% <ø> (ø)
... and 17 more

@wpbonelli wpbonelli marked this pull request as ready for review October 5, 2023 17:50
@wpbonelli
Copy link
Member Author

not needed after #1980

@wpbonelli wpbonelli closed this Oct 6, 2023
@wpbonelli wpbonelli deleted the pandas branch October 6, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant