feat(theseus): add category filter to mods within instance #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # apps/app/src/pages/Browse.vue # apps/app/src/pages/instance/Mods.vue
|
might reopne in the futher |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a category selector to the mod's view
this would lay the groundwork to close #1091, #1059, #875
I would add further filter options in additional PRs so this one does not get too big
currently when
allis selected as a project type all possible categories are shown. This is kinda of a lot so maybe the category filter should only be shown when some specific project type is chosen. But I think this would kinda hide the feature and people would think that the filters don't exist.An alternative "fix" would be to only show categories that some project uses.
reopen of #1158