feat(theseus): select mod icon as instance icon #1268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # theseus_gui/src/components/ui/Instance.vue # theseus_gui/src/pages/instance/Index.vue
…ce-icons # Conflicts: # apps/app/src/components/ui/Instance.vue # apps/app/src/pages/instance/Options.vue
|
might reopen in the future |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional way of selecting an icon for your instance. Using an icon from one of the mods in the instance.
based on the search-dropdown
I am not completely happy with the way the icon options look. Thoughts about removing the preview since it is in the bar on the left anyway?
the options would then look like this:
note:
I think it would be good to also locally cache the mod-based icons. I would do this in an additional Pr since I don't think it is necessary for this feature to work.
reopen of #1119