Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to SQLite for Internal Launcher Data #1300

Merged
merged 22 commits into from
Jul 24, 2024
Merged

Conversation

Geometrically
Copy link
Member

@Geometrically Geometrically commented Jul 17, 2024

This PR migrates the launcher's internal data structure to be SQLite based. This allows for ease of updating, better performance, stability, and more.

This PR also changes the default launcher directory to fix issues with Minecraft NBT saving.

This should also fix several issues/bugs in the app, including:

  • Profiles disappearing
  • Freezing issues
  • Infinite profile installs

This is still heavily WIP. TODO to merge:

  • Re-add methods for managing a profile's projects (add, remove, list, disable/enable)
  • Re-add profile groups
  • Rewrite/reimpl FS watcher for crash reports and caching profile projects
  • Reimplement updating and update-checking functionality for projects
  • Re-add ability to change launcher directory
  • Add migrators for existing launcher users to migrate to SQLite database
  • Move Minecraft Auth Data to SQLite DB
  • Move Modrinth Credentials to SQLite DB
  • Move Process Manager to SQLite DB
  • Fix/test profile importers (both external launchers and modrinth packs)
  • Fix/test Modrinth pack exporting
  • Update UI for compatibility with API changes
  • Remove constant offline mode check

Fixes #1048
Fixes #682
Fixes #1138
Fixes #767
Fixes #998
Fixes #1303
Fixes #1225
Fixes #1219
Fixes #1191
Fixes #1129
Fixes #1049
Fixes #980
Fixes #966
Fixes #919
Fixes #851
Fixes #905
Fixes #797
Fixes #700
Fixes #568
Fixes #614
Fixes #927
Fixes #1168
Fixes #822

@github-actions github-actions bot temporarily deployed to Preview (launcher-db-overhual) July 17, 2024 06:29 Inactive
@Geometrically Geometrically changed the title Launcher db overhual Migrate to SQLite for Internal Launcher Data Jul 17, 2024
@github-actions github-actions bot temporarily deployed to Preview (launcher-db-overhual) July 17, 2024 06:41 Inactive
@github-actions github-actions bot temporarily deployed to Preview (launcher-db-overhual) July 18, 2024 02:14 Inactive
@github-actions github-actions bot temporarily deployed to Preview (launcher-db-overhual) July 18, 2024 03:40 Inactive
@github-actions github-actions bot temporarily deployed to Preview (launcher-db-overhual) July 19, 2024 06:21 Inactive
@github-actions github-actions bot temporarily deployed to Preview (launcher-db-overhual) July 20, 2024 00:10 Inactive
@github-actions github-actions bot temporarily deployed to Preview (launcher-db-overhual) July 20, 2024 00:18 Inactive
@github-actions github-actions bot temporarily deployed to Preview (launcher-db-overhual) July 20, 2024 00:50 Inactive
@github-actions github-actions bot temporarily deployed to Preview (launcher-db-overhual) July 20, 2024 00:50 Inactive
@github-actions github-actions bot temporarily deployed to Preview (launcher-db-overhual) July 20, 2024 02:27 Inactive
@github-actions github-actions bot temporarily deployed to Preview (launcher-db-overhual) July 21, 2024 02:01 Inactive
@github-actions github-actions bot temporarily deployed to Preview (launcher-db-overhual) July 23, 2024 01:19 Inactive
@github-actions github-actions bot temporarily deployed to Preview (launcher-db-overhual) July 23, 2024 01:30 Inactive
@github-actions github-actions bot temporarily deployed to Preview (launcher-db-overhual) July 24, 2024 05:05 Inactive
@Geometrically Geometrically marked this pull request as ready for review July 24, 2024 05:05
@github-actions github-actions bot temporarily deployed to Preview (launcher-db-overhual) July 24, 2024 05:19 Inactive
@github-actions github-actions bot temporarily deployed to Preview (launcher-db-overhual) July 24, 2024 06:47 Inactive
@github-actions github-actions bot temporarily deployed to Preview (launcher-db-overhual) July 24, 2024 07:58 Inactive
@Geometrically Geometrically added this pull request to the merge queue Jul 24, 2024
Merged via the queue into main with commit 49a20a3 Jul 24, 2024
3 checks passed
@Geometrically Geometrically deleted the launcher-db-overhual branch July 24, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment