Bug fixes round 3 #298
Merged
Bug fixes round 3 #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-fan9823
approved these changes
Jul 1, 2023
Geometrically
requested changes
Jul 10, 2023
theseus/src/state/profiles.rs
Outdated
Comment on lines
380
to
394
| // Infer metadata from inferred downloaded project immediately, to avoid having to wait for the next sync | ||
| let synced_projects = state::infer_data_from_files( | ||
| self.clone(), | ||
| vec![path.clone()], | ||
| state.directories.caches_dir(), | ||
| &state.io_semaphore, | ||
| &state.fetch_semaphore, | ||
| ) | ||
| .await?; | ||
| let mut new_profiles = state.profiles.write().await; | ||
| if let Some(profile) = new_profiles.0.get_mut(&self.path) { | ||
| for (path, project) in synced_projects { | ||
| profile.projects.insert(path, project); | ||
| } | ||
| } |
There was a problem hiding this comment.
we should not do this imo, the debouncer already watches this
Geometrically
approved these changes
Jul 19, 2023
This was referenced Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149 #150 #156 #157 #165 #173 #176 #177 #189 #203 #211 #212 #224 #230 #265 #269 #270