Folder names #318
Merged
Folder names #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geometrically
requested changes
Jul 19, 2023
Comment on lines
+842
to
+853
| pub fn sync_available_profiles_task(profile_path_id: ProfilePathId) { | ||
| tokio::task::spawn(async move { | ||
| let span = tracing::span!( | ||
| tracing::Level::INFO, | ||
| "sync_available_profiles_task" | ||
| ); | ||
| let res = async { | ||
| let _span = span.enter(); | ||
| let state = State::get().await?; | ||
| let dirs = &state.directories; | ||
| let mut profiles = state.profiles.write().await; | ||
|
|
There was a problem hiding this comment.
Current debouncer watches inside profile folders and can update projects when the internal structure of the profile changes
I added the debouncer to watch the instances folder ( the profiles themselves) and this is triggered when that updates (eg: we are adding a whole new profile)
Geometrically
approved these changes
Jul 21, 2023
Geometrically
approved these changes
Jul 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes MOD-457
Fixes MOD-500