add open in app button to mod & modpack project pages #1731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We had planned on implementing it a different way, but I think doing it this way would be great for now! One thing is, this should work for anything except for a mod that only supports plugin loaders I believe, since the Modrinth App supports everything but plugins. |
|
I think it should be correct now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that theseus takes 'modrinth://' deeplinks for mods and modpacks
I thought it would be nice to add an 'open in app' button to those pages
because as far as I know there is currently no way (other than pasting code into console)
to use unlisted mods or modpacks in the launcher
and this could be a convenient way to make that a bit better
along with just being a nice qol feature
the-thing.mp4
I wasn't sure about making a thread for this in discord but can if needed!