Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modpack Export incorrectly sets mod.env.server to required #911

Open
ChristopherJTrent opened this issue Nov 27, 2023 · 0 comments · May be fixed by #1148
Open

Modpack Export incorrectly sets mod.env.server to required #911

ChristopherJTrent opened this issue Nov 27, 2023 · 0 comments · May be fixed by #1148
Labels
bug Something isn't working

Comments

@ChristopherJTrent
Copy link

ChristopherJTrent commented Nov 27, 2023

Describe the bug

When I exported my modpack to upload to Modrinth's site, the modrinth.index.json file has, for each mod, the following settings set by default without an override option:

{
    ...
    "env": {
        "server": "required",
        "client": "required"
    },
    ...
}

This causes issues with itzg's "docker-minecraft-server" docker image which respects those settings and loads client-only mods on the server, causing crashes.

Steps to reproduce

  • Create a modpack in the modrinth app
  • Add a client-side mod (such as Rubidium)
  • Export the modpack

Expected behavior

[Opinion] There should be an option (maybe a gear icon on the mod entry in the modpack) whereby one could set the client and server flags for each individual mod.

System information

OS: Windows 10 10.0.19045
Modrinth App 0.6.1 originally (Now updated to 0.6.2 where the issue persists.)

Additional context

https://discord.com/channels/734077874708938864/1178466741496594462
Associated support request in the discord.
https://modrinth.com/modpack/ark-serv/version/0.1.0
Associated modpack link.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

1 participant