Mark client-only mods as unsupported for servers in exports #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you export a mrpack all mods are always marked as required. This generally works fine for the client, since most "server-only" mods usually target the logical server and are still useful in single player.
For servers, however, this causes many issues. "Client-only" mods often cause crashes when running on a dedicated server.
This PR marks mods that do not support servers as unsupported on the server, which fixes #911 and #1081.
Ideally, the modpack author would have the option to pick which mods to include on the server and client and which mods should be optional. The behavior of this PR should still be the default selection for this menu due to the reasons mentioned above.