Skip to content

Conversation

michaelleejl
Copy link
Collaborator

No description provided.

@michaelleejl michaelleejl requested a review from yallop October 6, 2025 22:38
Location.prerr_warning Location.none (Warnings.Maco_dev
("avoided gadt constraint at level "^(string_of_int staging_level)))
else begin
begin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this removes too much: we don't need the warning, but we probably do still need the check staging_mode <> M_C that guards the else branch.

@yallop
Copy link
Member

yallop commented Oct 13, 2025

I've filtered out the unrelated ocamldoc dependency changes in .depend (1ac6272, 1db20b3); I'm not sure why make alldepend introduced them, but we don't need to resolve that here. @michaelleejl, are you happy for me to squash-merge this PR now?

@yallop yallop merged commit 8b9c55b into macocaml-5.3.0 Oct 13, 2025
4 of 14 checks passed
@yallop yallop deleted the remove-warning-for-levelled-gadts branch October 13, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants