Removed warning for levelled GADTs #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yallop
reviewed
Oct 6, 2025
| Location.prerr_warning Location.none (Warnings.Maco_dev | ||
| ("avoided gadt constraint at level "^(string_of_int staging_level))) | ||
| else begin | ||
| begin |
There was a problem hiding this comment.
I think this removes too much: we don't need the warning, but we probably do still need the check staging_mode <> M_C that guards the else branch.
yallop
reviewed
Oct 7, 2025
Co-authored-by: Jeremy Yallop <[email protected]>
This reverts commit 5aa8168.
|
I've filtered out the unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.