Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@shashankprasanna here are the changes I did to make sure centroids are initialized same way for all three implementations (kmeans_plus_plus is now in utils). I did other minor changes to practice and gain confidence with Mojo. Also, had to change some things to work with latest Mojo release.
I doubt that Sklearn performs less iterations, since with the change to how centroids are initialized, I am always getting same inertia in all three implementations which makes the benchmarks fairer.
I did not know how to contact you otherwise, you can ignore this pull request of course.