-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stdlib] add benchmark for lcm and gcd #3041
Open
bgreni
wants to merge
1
commit into
modularml:nightly
Choose a base branch
from
bgreni:add-lcm-gcd-benchmark
base: nightly
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+43
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeLoser
reviewed
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!sync
!sync |
modularbot
added
the
imported-internally
Signals that a given pull request has been imported internally.
label
Jun 14, 2024
bgreni
force-pushed
the
add-lcm-gcd-benchmark
branch
2 times, most recently
from
June 17, 2024 21:57
e1202b4
to
3a53b3a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
bgreni
force-pushed
the
add-lcm-gcd-benchmark
branch
2 times, most recently
from
June 17, 2024 22:48
4b9a6c6
to
3e47510
Compare
bgreni
force-pushed
the
add-lcm-gcd-benchmark
branch
4 times, most recently
from
July 2, 2024 22:34
1831c5c
to
afd0489
Compare
bgreni
force-pushed
the
add-lcm-gcd-benchmark
branch
2 times, most recently
from
July 11, 2024 02:16
a33a17b
to
b2d5887
Compare
bgreni
force-pushed
the
add-lcm-gcd-benchmark
branch
from
July 16, 2024 22:52
b2d5887
to
a5b833b
Compare
modularbot
pushed a commit
that referenced
this pull request
Jul 17, 2024
There's no need for `math.lcm` to take ownership of its arguments. Remove the `owned` keyword so the default argument convention of `borrowed` is used for the function arguments. This will also simplify #3041. MODULAR_ORIG_COMMIT_REV_ID: 782c1016c7fe287fc21115504e75098431fe80dd
bgreni
force-pushed
the
add-lcm-gcd-benchmark
branch
from
July 17, 2024 20:10
a5b833b
to
397aed6
Compare
When importing this and playing with it (and adding a necessary |
bgreni
force-pushed
the
add-lcm-gcd-benchmark
branch
from
August 4, 2024 20:16
397aed6
to
c0fd1d4
Compare
bgreni
force-pushed
the
add-lcm-gcd-benchmark
branch
from
September 8, 2024 02:58
c0fd1d4
to
3052543
Compare
modularbot
pushed a commit
that referenced
this pull request
Sep 13, 2024
There's no need for `math.lcm` to take ownership of its arguments. Remove the `owned` keyword so the default argument convention of `borrowed` is used for the function arguments. This will also simplify #3041. MODULAR_ORIG_COMMIT_REV_ID: 782c1016c7fe287fc21115504e75098431fe80dd
Signed-off-by: Brian Grenier <[email protected]>
bgreni
force-pushed
the
add-lcm-gcd-benchmark
branch
from
September 18, 2024 01:45
3052543
to
35fcdce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
blocked
Blocked by another issue that must be resolved first
imported-internally
Signals that a given pull request has been imported internally.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add benchmarks for
lcm
andgcd
functions