[stdlib] Add normpath, splitroot based on python implementation #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Diggins <[email protected]>
jdiggins
force-pushed
the
implement-os-path-normpath
branch
from
93117b8
to
bf58b3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2962
Implementation for both
os.path.normpathas well asos.path.splitroot, asnormpathdepends onsplitroot. I'm happy to movesplitrootinto its own PR, but it seemed straight forward enough to bring in here.Both implementations are based on python. The normpath implementation differs at the end as I wasn't able to use
sep.join