Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] Cleanup polynomial.mojo, improve docstring #3066

Open
wants to merge 1 commit into
base: nightly
Choose a base branch
from
Open

[stdlib] Cleanup polynomial.mojo, improve docstring #3066

wants to merge 1 commit into from

Conversation

soraros
Copy link
Contributor

@soraros soraros commented Jun 17, 2024 •
edited
Loading

  • Small simplification to the function _horner_evaluate.
  • Improve its docstring to match the argument names.
  • Finish off removing unroll by cleaning up the imports.

@soraros soraros marked this pull request as ready for review June 18, 2024 16:47
@soraros soraros requested a review from a team as a code owner June 18, 2024 16:47
@JoeLoser JoeLoser requested a review from abduld June 18, 2024 16:50
JoeLoser
JoeLoser approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@JoeLoser JoeLoser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Do you mind fixing up the merge conflicts and then I'm happy to merge this?

@soraros soraros force-pushed the remove-unroll-polynomial branch 2 times, most recently from a9980fa to b8f83ba Compare June 20, 2024 23:48
@soraros
[stdlib] Improve _horner_evaluate docstring
15322f7 
- Small simplification to the function `_horner_evaluate`.
- Improve its docstring to match the argument names.
- Finish off removing `unroll` by cleaning up the imports.

Signed-off-by: Yiwu Chen <[email protected]>
@soraros
Copy link
Contributor Author

soraros commented Jun 20, 2024 •
edited
Loading

@JoeLoser It seems that Abdul already removed the unroll in a1cba9d. I think the cleanup is still worthwhile, but I will let you decide if we still want to merge this.

@JoeLoser
Copy link
Collaborator

@JoeLoser It seems that Abdul already removed the unroll in a1cba9d. I think the cleanup is still worthwhile, but I will let you decide if we still want to merge this.

+1 to the cleanup. Mind retitling the PR/description to match the current cleanup then? Thanks!

@soraros soraros changed the title [stdlib] Move polynomial.mojo off unroll [stdlib] Cleanup polynomial.mojo, improve docstring Jun 21, 2024
@JoeLoser
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeLoser JoeLoser JoeLoser approved these changes

@abduld abduld Awaiting requested review from abduld

Assignees

@JoeLoser JoeLoser

Labels
imported-internally Signals that a given pull request has been imported internally.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@soraros @JoeLoser @modularbot