Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stdlib] Fix String.removesuffix("") removing entire string. #3118

Closed
wants to merge 1 commit into from

Conversation

helehex
Copy link
Contributor

@helehex helehex commented Jun 25, 2024

A fix to #3117

@helehex helehex requested a review from a team as a code owner June 25, 2024 02:30
@ConnorGray
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Jun 25, 2024
@modularbot
Copy link
Collaborator

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@modularbot modularbot added merged-internally Indicates that this pull request has been merged internally merged-externally Merged externally in public mojo repo labels Jun 29, 2024
modularbot pushed a commit that referenced this pull request Jul 1, 2024
…ing. (#42239)

[External] [stdlib] Fix `String.removesuffix("")` removing entire
string.

A fix to #3117

Co-authored-by: Helehex <[email protected]>
Closes #3118
MODULAR_ORIG_COMMIT_REV_ID: 22f22e0ec077e0a215417607987807b694652605
@modularbot
Copy link
Collaborator

Landed in c7cc7e2! Thank you for your contribution 🎉

@modularbot modularbot closed this Jul 1, 2024
modularbot pushed a commit that referenced this pull request Sep 13, 2024
…ing. (#42239)

[External] [stdlib] Fix `String.removesuffix("")` removing entire
string.

A fix to #3117

Co-authored-by: Helehex <[email protected]>
Closes #3118
MODULAR_ORIG_COMMIT_REV_ID: 22f22e0ec077e0a215417607987807b694652605
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imported-internally Signals that a given pull request has been imported internally. merged-externally Merged externally in public mojo repo merged-internally Indicates that this pull request has been merged internally
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants