[stdlib] Add static method InlineArray.unsafe_uninitialized()
#3122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gabrieldemarmiesse <[email protected]>
Signed-off-by: gabrieldemarmiesse <[email protected]>
Signed-off-by: gabrieldemarmiesse <[email protected]>
Signed-off-by: gabrieldemarmiesse <[email protected]>
Signed-off-by: gabrieldemarmiesse <[email protected]>
gabrieldemarmiesse
changed the title
InlineArray.unsafe_uninitialized()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires #3119 to be merged first.
Note that I would like this method to be in the future
UnlineArray[UnsafeMaybeUninitialized[...], ...]()in the future, but we currently have no way to verify that the generic type of the elements isUnsafeMaybeUninitializedso that will have to wait.I'm not sure if this PR is fully correct. Is it okay to work with pointers on uninitialized data like this? Maybe the code was already wrong to begin with?
@ConnorGray for review as you are the one following the work in this area.