Skip to content

Modernize modular scale #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 64 commits into
base: 3.x
Choose a base branch
from
Open

Modernize modular scale #172

wants to merge 64 commits into from
+7,882 −4,980

Conversation

@scottkellum
Copy link
Member

Bring Modular Scale up to current Sass standards.

@scottkellum scottkellum mentioned this pull request Jun 25, 2021
Open
@scottkellum
Copy link
Member Author

Please test this out here: https://github.com/modularscale/modularscale-sass/releases/tag/v4.0.0.rc1

@robsonsobral
Copy link
Collaborator

Hi, Scott!

Why not to move the _modularscale.scss to modularscale/_index.scss? The @use stays the same, but the files are kept all within a single folder.

I'm sorry for bother you twice in a day.

@scottkellum
Copy link
Member Author

@robsonsobral Not a bother! Happy to get feedback!

robsonsobral and others added 26 commits August 6, 2021 14:38
@robsonsobral
Add tests to step() function
263b30d
@robsonsobral
Allow the use of target as "step"
79c209b
@robsonsobral
Accept incompatible units on step(12px) using 16px as root size
d37b9fd
@robsonsobral
Remove use of @import
1fa6c0e
@robsonsobral
Improve reversed steps tests
d7a4559
@robsonsobral
Test settings normalizer
a797012
@robsonsobral
Improve test script
e40cfd7
@robsonsobral
Add multiple scales to step() test
c04b832
@robsonsobral
Lint the code
169be4a
@robsonsobral
Rename "vars" as "constants"
aa4e543
@robsonsobral
Kill a gremlin
bfd03e9 
https://marketplace.visualstudio.com/items?itemName=nhoizey.gremlins
@robsonsobral
Remove redundant code...
9ac3d33 
...because that's already the default settings
@robsonsobral
Fix multi bases step()
d6a41ec
@robsonsobral
Normalize quotation marks
379de7b
@robsonsobral
Call ratios by name...
78d7b05 
...in a shorter way than the previous one
@robsonsobral
Allow target to be provided as list, using spaces
beaec89
@robsonsobral
Prefix type-of()
01376ed
@robsonsobral
Rename target() to make its purpose clearer
c7a9e2b
@robsonsobral
Move step-by-target() to its own file
77a18bd
@robsonsobral
Rename settings() to normalize-settings()
0df0c33
@robsonsobral
Allow adding custom named ratios...
b7616a4 
..within settings map
@robsonsobral
Fix settings inheritance
6253f52
@robsonsobral
Combine API into one file to make easier to handle settings
a8a5c55
@robsonsobral
Fix settings overriding
e1eb838
@robsonsobral
Testing responsive mixins
d6e588c
@scottkellum
Merge pull request #174 from robsonsobral/4.x
e40dfa2
@robsonsobral
Copy link
Collaborator

@scottkellum ? Have you given it up?

@scottkellum
Copy link
Member Author

@robsonsobral Ha yeah I have no time for this for the next few months 😅🙃

@robsonsobral
Copy link
Collaborator

I think we have a good thing here, @scottkellum . Let's give it some time?

@scottkellum
Copy link
Member Author

Just want to let you know I see this and am trying to figure out how to allocate time to wrap this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

In progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scottkellum @robsonsobral