fix(dts-plugin): do not regen types on hmr if dev false

module-federation · Nov 14, 2024 · e9fd573 · e9fd573
1 parent 7facc10
commit e9fd573
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/.changeset/honest-yaks-smoke.md b/.changeset/honest-yaks-smoke.md
@@ -0,0 +1,5 @@
+---
+'@module-federation/dts-plugin': patch
+---
+
+ensure when dev is false that type generation only runs once
diff --git a/packages/dts-plugin/src/plugins/GenerateTypesPlugin.ts b/packages/dts-plugin/src/plugins/GenerateTypesPlugin.ts
@@ -72,7 +72,7 @@ export class GenerateTypesPlugin implements WebpackPluginInstance {
       return fn;
     };
     const generateTypesFn = getGenerateTypesFn();
-
+    let compiledOnce = false;
     compiler.hooks.thisCompilation.tap('mf:generateTypes', (compilation) => {
       compilation.hooks.processAssets.tapPromise(
         {
@@ -82,6 +82,9 @@ export class GenerateTypesPlugin implements WebpackPluginInstance {
             compilation.constructor.PROCESS_ASSETS_STAGE_OPTIMIZE_TRANSFER,
         },
         async () => {
+          if (pluginOptions.dev === false && compiledOnce) {
+            return;
+          }
           try {
             const { zipTypesPath, apiTypesPath, zipName, apiFileName } =
               retrieveTypesAssetsInfo(finalOptions.remote);
@@ -124,6 +127,7 @@ export class GenerateTypesPlugin implements WebpackPluginInstance {
                 ),
               );
             }
+            compiledOnce = true;
           } catch (err) {
             console.error(err);
           }