Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use real dirName instead of urlDirName #2906

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/serious-actors-run.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@module-federation/sdk': patch
---

chore: use real dirName instead of urlDirName
4 changes: 2 additions & 2 deletions packages/sdk/src/node.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ export function createScriptNode(
]);

const scriptContext = { exports: {}, module: { exports: {} } };
const urlDirname = urlObj.pathname.split('/').slice(0, -1).join('/');
// const urlDirname = urlObj.pathname.split('/').slice(0, -1).join('/');
const filename = path.basename(urlObj.pathname);

const script = new vm.Script(
Expand All @@ -109,7 +109,7 @@ export function createScriptNode(
scriptContext.exports,
scriptContext.module,
eval('require'),
urlDirname,
__dirname,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be dirname of your current directory of evaluation, is that okay?

filename,
);

Expand Down
Loading