WIP: perf: reduce chunk map if remote entry chunk #2911
Conversation
|
![squadronai[bot]](https://avatars.githubusercontent.com/in/901096?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary
Here is a concise summary of the pull request:
This pull request aims to optimize the performance of the RemoteRuntimeModule and ConsumeSharedRuntimeModule by introducing conditional logic to use a smaller chunk map for remote entry chunks, while maintaining the full chunk map for "host" runtimes. The changes attempt to reduce the amount of data that needs to be processed and transferred, which should improve overall performance. The pull request focuses on integrating these optimizations into the existing codebase, with the goal of enhancing the efficiency of the remote entry and shared runtime handling.
File Summaries
| File | Summary |
|---|---|
| packages/enhanced/src/lib/container/RemoteRuntimeModule.ts | The code changes attempt to optimize the chunk map handling in the RemoteRuntimeModule. It introduces a conditional logic to use a smaller chunk map for remote entry chunks, while maintaining the full chunk map for "host" runtimes. This aims to improve performance by reducing the amount of data that needs to be processed and transferred. |
| packages/enhanced/src/lib/sharing/ConsumeSharedRuntimeModule.ts | The code changes introduce an optimization to the ConsumeSharedRuntimeModule by using an async chunk map for remote entry chunks and a full chunk map for "host" runtimes. This aims to improve performance by reducing the amount of data that needs to be processed for the chunk map. |
There was a problem hiding this comment.
Incremental Review
Comments posted: 0
Configuration
Squadron Mode: essential
Commits Reviewed
b314d42042a1bd6c3e93b533be0c75a0415b10ac...7c60d1f0f778754fc9f3158a95eb8aa54aad9cf9
Files Reviewed
- packages/enhanced/src/lib/container/RemoteRuntimeModule.ts
- packages/enhanced/src/lib/sharing/ConsumeSharedRuntimeModule.ts
There was a problem hiding this comment.
Incremental Review
Comments posted: 0
Configuration
Squadron Mode: essential
Commits Reviewed
46ff6feb42d5efdba0a58a2039ae05e45e3ebf8c...7c60d1f0f778754fc9f3158a95eb8aa54aad9cf9
Files Reviewed
- packages/enhanced/src/lib/container/RemoteRuntimeModule.ts
- packages/enhanced/src/lib/sharing/ConsumeSharedRuntimeModule.ts
There was a problem hiding this comment.
Incremental Review
Comments posted: 0
Configuration
Squadron Mode: essential
Commits Reviewed
7c60d1f0f778754fc9f3158a95eb8aa54aad9cf9...93d6502c54b65cfe4a72c92a597ca235ab664274
Files Reviewed
- packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
There was a problem hiding this comment.
Incremental Review
Comments posted: 1
Configuration
Squadron Mode: essential
Commits Reviewed
93d6502c54b65cfe4a72c92a597ca235ab664274...56bd582171940e3f5f902942a0ecd24a1e58e37f
Files Reviewed
- packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
There was a problem hiding this comment.
Incremental Review
Comments posted: 0
Configuration
Squadron Mode: essential
Commits Reviewed
56bd582171940e3f5f902942a0ecd24a1e58e37f...472288f50c28988c627fbf385af9745f4c0ec516
Files Reviewed
- packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- webpack/types.d.ts
There was a problem hiding this comment.
Incremental Review
Comments posted: 0
Configuration
Squadron Mode: essential
Commits Reviewed
472288f50c28988c627fbf385af9745f4c0ec516...23e818abcec501610400378e1a5c840624b199a2
Files Reviewed
- packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- webpack/types.d.ts
There was a problem hiding this comment.
Incremental Review
Comments posted: 3
Configuration
Squadron Mode: essential
Commits Reviewed
23e818abcec501610400378e1a5c840624b199a2...f9e146d240a5ca91a01a26361da005404520d409
Files Reviewed
- packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- webpack/types.d.ts
There was a problem hiding this comment.
Incremental Review
Comments posted: 0
Configuration
Squadron Mode: essential
Commits Reviewed
f9e146d240a5ca91a01a26361da005404520d409...ed8b69a3c158edf06e354355688051772978c3f3
Files Reviewed
- packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- webpack/types.d.ts
There was a problem hiding this comment.
Incremental Review
Comments posted: 0
Configuration
Squadron Mode: essential
Commits Reviewed
828daa284a097b95f5c8d726bc9f81741b0ff5c4...e82390482d54280d24466d158a45d93ec784f72e
Files Reviewed
- packages/enhanced/src/lib/container/HoistContainerReferencesPlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- apps/3000-home/cypress/e2e/app.cy.ts
- webpack/types.d.ts
There was a problem hiding this comment.
Incremental Review
Comments posted: 0
Configuration
Squadron Mode: essential
Commits Reviewed
e82390482d54280d24466d158a45d93ec784f72e...9a9f707a22c2ed96283940f4f1ef95edce0a4964
Files Reviewed
- packages/enhanced/src/lib/container/HoistContainerReferencesPlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- apps/3000-home/cypress/e2e/app.cy.ts
- webpack/types.d.ts
There was a problem hiding this comment.
Incremental Review
Comments posted: 0
Configuration
Squadron Mode: essential
Commits Reviewed
9a9f707a22c2ed96283940f4f1ef95edce0a4964...09129c1bb5e8099d3481dc8882197956a30fed75
Files Reviewed
- packages/enhanced/src/lib/container/HoistContainerReferencesPlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- apps/3000-home/cypress/e2e/app.cy.ts
- webpack/types.d.ts
There was a problem hiding this comment.
Incremental Review
Comments posted: 0
Configuration
Squadron Mode: essential
Commits Reviewed
09129c1bb5e8099d3481dc8882197956a30fed75...e64f7ed97b45a89b1b78398a3a7d28e14458e96b
Files Reviewed
- packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- apps/3000-home/cypress/e2e/app.cy.ts
- webpack/types.d.ts
# Conflicts: # packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Incremental Review
Comments posted: 0
Configuration
Squadron Mode: essential
Commits Reviewed
e64f7ed97b45a89b1b78398a3a7d28e14458e96b...98afaffc308922ee3b46faea7cfa598d3dd1c99f
Files Reviewed
- packages/enhanced/src/lib/container/runtime/FederationRuntimePlugin.ts
Files Ignored
These files were ignored due to the filter in the squadron.yaml file.
- apps/3000-home/cypress/e2e/app.cy.ts
- webpack/types.d.ts
Description
attempt to use async chunk map in remote entry and all chunk map in "host" runtimes
Related Issue
Types of changes
Checklist