Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dts-plugin): do not regen types on hmr if dev false #3223

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(dts-plugin): do not regen types on hmr if dev false #3223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9fd573
fix(dts-plugin): do not regen types on hmr if dev false
ScriptedAlchemy Nov 14, 2024
710e92c
Merge branch 'main' into fix/dev-false-dts-regen
ScriptedAlchemy Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/honest-yaks-smoke.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@module-federation/dts-plugin': patch
---

ensure when dev is false that type generation only runs once
6 changes: 5 additions & 1 deletion packages/dts-plugin/src/plugins/GenerateTypesPlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ export class GenerateTypesPlugin implements WebpackPluginInstance {
return fn;
};
const generateTypesFn = getGenerateTypesFn();

let compiledOnce = false;
compiler.hooks.thisCompilation.tap('mf:generateTypes', (compilation) => {
compilation.hooks.processAssets.tapPromise(
{
Expand All @@ -82,6 +82,9 @@ export class GenerateTypesPlugin implements WebpackPluginInstance {
compilation.constructor.PROCESS_ASSETS_STAGE_OPTIMIZE_TRANSFER,
},
async () => {
if (pluginOptions.dev === false && compiledOnce) {
return;
}
try {
const { zipTypesPath, apiTypesPath, zipName, apiFileName } =
retrieveTypesAssetsInfo(finalOptions.remote);
Expand Down Expand Up @@ -124,6 +127,7 @@ export class GenerateTypesPlugin implements WebpackPluginInstance {
),
);
}
compiledOnce = true;
} catch (err) {
console.error(err);
}
Expand Down
Loading