-
-
Notifications
You must be signed in to change notification settings - Fork 362
fix(enhanced): Add fallback parsing for container module exposes (#4034) #4083
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
1dc6591
fix(enhanced): Add fallback parsing for container module exposes (#4034)
vinicius-at-webflow d5a31a1
fix(manifest): parse container exposes without splitting
ScriptedAlchemy 21e59b5
refactor(manifest): seed exposes from options
ScriptedAlchemy 3e797c9
Merge branch 'main' into container-json-parse
ScriptedAlchemy ea4f581
Merge branch 'main' into container-json-parse
ScriptedAlchemy 97f75ac
fix(manifest): normalize exposes fallback in module handler
ScriptedAlchemy 8c6f909
Merge branch 'main' into container-json-parse
ScriptedAlchemy 373f396
test: align resolveMatchedConfigs with webpack
ScriptedAlchemy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 6 additions & 0 deletions
6
packages/enhanced/test/configCases/container/expose-edge-cases/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| it('should be able to handle spaces in path to exposes', async () => { | ||
| const { default: test1 } = await import('./test 1'); | ||
| const { default: test2 } = await import('./path with spaces/test-2'); | ||
| expect(test1()).toBe('test 1'); | ||
| expect(test2()).toBe('test 2'); | ||
| }); |
3 changes: 3 additions & 0 deletions
3
packages/enhanced/test/configCases/container/expose-edge-cases/path with spaces/test-2.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export default function test() { | ||
| return 'test 2'; | ||
| } |
3 changes: 3 additions & 0 deletions
3
packages/enhanced/test/configCases/container/expose-edge-cases/test 1.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export default function test() { | ||
| return 'test 1'; | ||
| } |
20 changes: 20 additions & 0 deletions
20
packages/enhanced/test/configCases/container/expose-edge-cases/webpack.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| const { ModuleFederationPlugin } = require('../../../../dist/src'); | ||
|
|
||
| module.exports = { | ||
| mode: 'development', | ||
| devtool: false, | ||
| output: { | ||
| publicPath: 'http://localhost:3000/', | ||
| }, | ||
| plugins: [ | ||
| new ModuleFederationPlugin({ | ||
| name: 'remote', | ||
| filename: 'remoteEntry.js', | ||
| manifest: true, | ||
| exposes: { | ||
| './test-1': './test 1.js', | ||
| './test-2': './path with spaces/test-2.js', | ||
| }, | ||
| }), | ||
| ], | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Normalize fallback exposes before accessing import
When JSON parsing of
identifierfails, the code falls back tothis._options.exposesand iterates the entries assuming each value already looks like{ import: [...] }. For typical module federation configs the values are plain strings (e.g.exposes: { './foo': './foo.js' }), sofileis a string andfile.import[0]throws, causing the Stats plugin to crash in the same spaces-in-path scenario this change is supposed to fix. The fallback needs to normalize string/array expose definitions into an object with animportarray (or skip them) before dereferencingfile.import.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@codex fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary
isNonEmptyStringhelper and used it to sanitize container expose definitions when parsing identifiers fails, reusing normalized plugin options and ignoring entries without valid import paths. packages/manifest/src/ModuleHandler.tsL27-L29 packages/manifest/src/ModuleHandler.tsL364-L414Testing
pnpm exec jest --config packages/manifest/jest.config.jsView task →