Skip to content

test: change config - #7

Merged
gioboa merged 1 commit into
mainfrom
test/remote-config
Aug 12, 2026
Merged

gioboa merged 1 commit into
mainfrom
test/remote-config

Conversation

@gioboa

@gioboa gioboa commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@pkg-pr-new

pkg-pr-new Bot commented Aug 12, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@module-federation/vinext@7

commit: 7ceb844

@gioboa
gioboa force-pushed the test/remote-config branch from 2b66835 to 47f13d7 Compare August 12, 2026 15:09
@gioboa gioboa changed the title test: change remote config test: change config Aug 12, 2026
@gioboa
gioboa force-pushed the test/remote-config branch 2 times, most recently from 51d7138 to 9c01535 Compare August 12, 2026 16:23
@dmchoi77

dmchoi77 commented Aug 12, 2026 •

Copy link
Copy Markdown
Contributor

@gioboa It looks like the island Vite config might be missing the SSR build options.
The remote config already has a similar setup. After upgrading to @module-federation/vite@1.20.5, the E2E test started timing out. Adding the following locally makes it pass:

// apps/island/vite.config.ts
builder: {},
environments: {
  ssr: {
    build: {
      ssr: "./src/counter.tsx",
      outDir: "dist/ssr",
    },
  },
},

@gioboa
gioboa force-pushed the test/remote-config branch 2 times, most recently from 61a4c2b to a987d24 Compare August 12, 2026 20:42
@gioboa
gioboa force-pushed the test/remote-config branch from a987d24 to 7ceb844 Compare August 12, 2026 20:43

@gioboa gioboa left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your hint @dmchoi77

@gioboa
gioboa merged commit a6f6c91 into main Aug 12, 2026
4 checks passed
@gioboa
gioboa deleted the test/remote-config branch August 12, 2026 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants