Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated for new site compatibility #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Fenrisulfir
Copy link

@Fenrisulfir Fenrisulfir commented Jul 22, 2016

Hotfixed config settings and data scraping
Needs to search timezones
Probably needs a lot of validation
Super gross regex construction

@Fenrisulfir Fenrisulfir changed the title Updated for new site compatability Updated for new site compatibility Aug 16, 2016
Pulls all data and saves config settings

Review and Improved
@module17
Copy link
Owner

Initial run shows a warning when no config.yml exists.

Warning: file_get_contents(src/../config.yml): failed to open stream: No such file or directory in src/Config.php on line 86

@module17
Copy link
Owner

How does the user know what format the timezone should be in?

********************************************************************************
******************************* tvscraper **************************************
********************************************************************************
Do you want to enter your timezone? EST

@module17
Copy link
Owner

Warning after answering yes. I suggest showing possible values at the end of the line. ie. (y/n)

Do you want to setup your display options? yes

Warning: Invalid argument supplied for foreach() in /Users/module17/repos/tvscraper-mike/src/Tvscraper.php on line 163

@module17
Copy link
Owner

Debug on by default?

POST h0h0h0 to http://www.tvpassport.com/index.php/lineups

@module17
Copy link
Owner

My first run results are not showing up.

Lineup Choice: 6


Params:
array(4) {
  ["lu"]=>
  string(4) "257D"
  ["st"]=>
  int(1471496065)
  ["et"]=>
  int(1471496065)
  ["tz"]=>
  NULL
}

ENDPOINT: http://www.tvpassport.com/tvlistings/tvlistings/listings

array(0) {
}

@module17
Copy link
Owner

Second run, it is asking for the same configuration values. Is it configured to save settings immediately and run with those values the following times? How is this controlled?

@module17
Copy link
Owner

I think we should implement some command line arguments. Start with --config or something along those lines. --help would be nice too.

@module17
Copy link
Owner

module17 commented Sep 2, 2016

Any updates @Fenrisulfir?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants