Skip to content

feat!: rewrite it in rust #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 23 commits into from
Closed

feat!: rewrite it in rust #28

wants to merge 23 commits into from

Conversation

kwaa
Copy link
Member

@kwaa kwaa commented May 2, 2025 •
edited
Loading

🦀

@kwaa kwaa added the enhancement New feature or request label May 2, 2025
@kwaa kwaa self-assigned this May 2, 2025
@sumimakito
Copy link
Member

Style: Shall we add a rustfmt.toml (or something alike) to keep the style consistent? E.g., tab_spaces has a default of 4, but we are using 2 in files in this pull request.

sumimakito
sumimakito approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@sumimakito sumimakito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me

@kwaa kwaa requested a review from sumimakito May 3, 2025 06:49
@kwaa kwaa marked this pull request as ready for review May 25, 2025 14:12
@kwaa kwaa closed this May 25, 2025
@kwaa
Copy link
Member Author

kwaa commented May 25, 2025

After some discussion, we decided to continue with the existing Golang version

@kwaa kwaa deleted the feat/riir branch May 25, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumimakito sumimakito Awaiting requested review from sumimakito

Assignees

@kwaa kwaa

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwaa @sumimakito @nekomeowww