Skip to content

feat(bench): add baseline benchmark capture and CI regression check #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aaniya22 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(bench): add baseline benchmark capture and CI regression check #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12472dd
feat(bench): add baseline benchmark capture and CI regression check (…
aaniya22 Jul 15, 2026
8cb1073
fix(ci): correct bench-compare job indentation
aaniya22 Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,6 @@ jobs:
with:
key: msrv
- run: cargo build --workspace --all-features

# ── Benchmark compile check ──────────────────────────────────────────────────
bench-check:
name: Benchmarks Compile
Expand All @@ -137,6 +136,32 @@ jobs:
- uses: Swatinem/rust-cache@v2
- run: cargo bench --workspace --no-run --all-features

# ── Benchmark regression check (PR only, non-blocking — informational) ───────
bench-compare:
name: Benchmark Regression Check
runs-on: ubuntu-latest
needs: [fmt, clippy]
if: github.event_name == 'pull_request'
continue-on-error: true
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
with:
key: bench-compare
- name: Install critcmp
run: cargo install critcmp --locked
- name: Run benchmarks on PR branch
run: cargo bench -p mohu-buffer --bench ndarray_ops -- --save-baseline pr
- name: Compare against committed baseline
run: |
echo "## Benchmark comparison vs \`benches/baselines/main.json\`" >> "$GITHUB_STEP_SUMMARY"
echo '```' >> "$GITHUB_STEP_SUMMARY"
critcmp benches/baselines/main.json pr >> "$GITHUB_STEP_SUMMARY"
echo '```' >> "$GITHUB_STEP_SUMMARY"
echo "" >> "$GITHUB_STEP_SUMMARY"
echo "Comparisons within ±5% are noise on shared CI runners. Larger deltas warrant a closer look before merging." >> "$GITHUB_STEP_SUMMARY"

# ── Semver (PR only; non-blocking until crates are published) ────────────────
semver:
name: Semver Check
Expand Down
215 changes: 215 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ tracing = "0.1"
# ── Testing ───────────────────────────────────────────────────────────────────
proptest = "1"
approx = "0.5"
criterion = { version = "0.5", features = ["html_reports"] }

# ── Build utilities ───────────────────────────────────────────────────────────
cfg-if = "1"
Expand Down
Loading
Loading