Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify version range for pytest-cov in CI #2489

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Conversation

ADBond
Copy link
Contributor

@ADBond ADBond commented Oct 30, 2024

pytest-cov 6.0.0 dropped support for python 3.8 support.

If we don't specify, poetry add will add it as ^6.0.0 (even when running on python 3.8). This causes dependency resolution to fail. Note that this happens even for the tests on python >= 3.9, as it finds that our general support for >=3.8 is incompatible with pytest-cov = ^6.0.0.

Output:

The current project's supported Python range (>=3.8.0,<4.0.0) is not compatible with some of the required packages Python requirement:
  - pytest-cov requires Python >=3.9, so it will not be satisfied for Python >=3.8.0,<3.9

Because no versions of pytest-cov match >6.0.0,<7.0.0
 and pytest-cov (6.0.0) requires Python >=3.9, pytest-cov is forbidden.
So, because splink depends on pytest-cov (^6.0.0), version solving failed.

For now we can add pytest-cov as >=5.0.0.

First hint of some friction with 3.8 - see #2476.

6.0.0 dropped 3.8 support, and if we don't specify, poetry will add it as ^6.0.0 even when using python 3.8, and so will fail resolution.
@ADBond ADBond added bug Something isn't working dependencies Pull requests that update a dependency file continuous integration labels Oct 30, 2024
@ADBond ADBond merged commit 2c0fde2 into master Oct 30, 2024
@ADBond ADBond deleted the ci/pytest-cov-version-pin branch October 30, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working continuous integration dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant