Pairwise string distance comparison#2517
Merged
RobinL merged 10 commits intomoj-analytical-services:masterfrom Dec 3, 2024
Merged
Pairwise string distance comparison#2517RobinL merged 10 commits intomoj-analytical-services:masterfrom
RobinL merged 10 commits intomoj-analytical-services:masterfrom
Conversation
… distance feature
…yShiUW/splink into pairwise_string_distance_comparison
RobinL
reviewed
Nov 25, 2024
RobinL
reviewed
Dec 1, 2024
Contributor
Author
|
@RobinL I believe I've addressed your comments. I don't understand why a test is failing -- it does not seem related in any way to these changes. |
Contributor
@zmbc you are correct - apologies this is an unrelated issue #2515 (which will be fixed shortly, so should not be an issue going forward). Have re-run it to get it to pass, for clarity. |
Member
|
Brilliant, thanks @zmbc and @JonnyShiUW this is great |
This was referenced Dec 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of PR
Is your Pull Request linked to an existing Issue or Pull Request?
This is a follow up to #2195, addressing the PR comments there. Closes #1994.
Give a brief description for the solution you have provided
As discussed in the prior PR, this mostly models
PairwiseStringDistanceFunctionAtThresholdsandPairwiseStringDistanceFunctionLeveloff ofDistanceFunctionAtThresholdsandDistanceFunctionLevelrespectively.
The main difference is that it is pairwise on an array column (duh) and that it only accepts a small list
of string distance functions and transpiles them, instead of the user passing an arbitrary SQL function.
PR Checklist