Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate master branch to main branch #167

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

oderayi
Copy link
Contributor

@oderayi oderayi commented Aug 28, 2023

chore: migrate from master branch to main branch

  • update ci config to use main branch
  • update docs references
  • update deps

@oderayi oderayi changed the title chore: rename refs to master to main chore: rename refs to master to main [skip ci] Aug 28, 2023
@oderayi oderayi changed the title chore: rename refs to master to main [skip ci] chore: rename refs to master to main Aug 28, 2023
@oderayi oderayi changed the title chore: rename refs to master to main chore: migrate master to main Aug 28, 2023
@oderayi oderayi changed the title chore: migrate master to main chore: migrate master branch to main branch Aug 28, 2023
Copy link
Member

@mdebarros mdebarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should put this on hold for the time being until we can update the other Mojaloop repos from master to main.

I have added some (Not all) suggested changes, i.e. revert all external dependencies changes that were searched-replaced from master -> main, back to master.

The reason for this is because Github is clever enough to be aware of the change, and if you hit a github repo that did a rename from master to main, using master, it will auto-magically forward you to the main branch showing you a warning message that the change has occured.

@@ -7,7 +7,7 @@ version: 2.1
# Orbs used in this pipeline
##
orbs:
slack: circleci/[email protected] # Ref: https://github.com/mojaloop/ci-config/tree/master/slack-templates
slack: circleci/[email protected] # Ref: https://github.com/mojaloop/ci-config/tree/main/slack-templates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
slack: circleci/[email protected] # Ref: https://github.com/mojaloop/ci-config/tree/main/slack-templates
slack: circleci/[email protected] # Ref: https://github.com/mojaloop/ci-config/tree/master/slack-templates

Reverting because this is external, and we cant manage that.

@@ -42,7 +42,7 @@ Validate the result file.
## Swagger-UI

The snippets specification is previewable using swagger-ui. Swagger-UI files
are found in `docs/dist/`. Github pages uses the master branch `docs/` folder
are found in `docs/dist/`. Github pages uses the `main` branch `docs/` folder
to build the page found at https://docs.mojaloop.io/api-snippets/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to build the page found at https://docs.mojaloop.io/api-snippets/
to build the page found at https://mojaloop.github.io/api-snippets

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every other change "URL" below this comment should be reverted from to master

@@ -17,7 +17,7 @@ info:
the term "FSP" is equal to the term "DFSP".
license:
name: Apache License Version 2.0, January 2004
url: https://github.com/mojaloop/documentation/blob/master/LICENSE.md
url: https://github.com/mojaloop/documentation/blob/main/LICENSE.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
url: https://github.com/mojaloop/documentation/blob/main/LICENSE.md
url: https://github.com/mojaloop/documentation/blob/master/LICENSE.md

@@ -4,7 +4,7 @@ info:
title: Thirdparty Snippets
description: |
Based on sequence diagrams
(https://github.com/mojaloop/pisp/tree/master/docs/out).
(https://github.com/mojaloop/pisp/tree/main/docs/out).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(https://github.com/mojaloop/pisp/tree/main/docs/out).
(https://github.com/mojaloop/pisp/tree/master/docs/out).

Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.9% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants