Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mongodb): add extended config options for MongoDB #831

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

lewisdaly
Copy link
Contributor

@lewisdaly lewisdaly commented Mar 31, 2021

  • Allows us to configure mongodb to use TLS connection
  • Adds integration tests for testing tls and non-tls connections with Mongodb

part of mojaloop/project#2100

Note: This is blocked by: mojaloop/object-store-lib#21

@@ -85,7 +85,7 @@
"@hapi/inert": "6.0.3",
"@hapi/joi": "17.1.1",
"@hapi/vision": "6.0.1",
"@mojaloop/central-object-store": "11.0.0-snapshot",
"@mojaloop/central-object-store": "git://github.com/vessels-tech/central-object-store.git#feat/2100-add-tls-config",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -314,6 +314,7 @@ Test('Participant service', async (participantTest) => {
}
})

// TODO: these integration tests are failing...
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: fix me!

@@ -401,6 +408,7 @@ Test('Handlers test', async handlersTest => {
test.end()
})

// TODO: fix this test!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: fix me!

// Act
await sleepPromise(15) // give the timeout handler some time to expire the request
const payerCurrentPosition = await ParticipantService.getPositionByParticipantCurrencyId(td.payer.participantCurrencyId) || {}
// TODO: fix me!
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: fix me!

@@ -151,6 +145,8 @@ Test('setup', setupTest => {
test.end()
})

// TODO: this testis invalid - the error is `TypeError: server.ext is not a function`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: fix me!

@elnyry-sam-k
Copy link
Member

@lewisdaly , this for the PR :-)

Would it be possible to bring this up to date, so that we can review & merge it? If not its getting stale and we may have to close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants