feat: migrate central settlement service docs #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meekg33k
requested review from
elnyry-sam-k,
kjw000,
lewisdaly,
mdebarros,
millerabel and
simeonoriko
as code owners
| @@ -0,0 +1,24 @@ | |||
| # Central-Settlements Service | |||
|
|
|||
| The Central Settlements service is part of the Mojaloop project and deployment. | |||
There was a problem hiding this comment.
Suggested change
| The Central Settlements service is part of the Mojaloop project and deployment. | |
| The Central Settlements service is part of the Mojaloop core. |
|
@meekg33k thanks for the PR; just two minor comments, one is inline. Are the two gitkeep files still needed? I see that we have other files in the folders, please review.. Everything else looks good. |
|
This doesn't look right to me, as it's changing files in If we merge this in, the next time we run a release, these changes would be removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated
Central Settlements Servicedocumentation.