dont overwrite tls_option #2148
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm afraid without a test this probably won't be considered. |
|
Don't think any TLS changes should be considered until our tests pass in github actions again. 5d83a17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tls_option(SSL_verifycn_name) is unconditionally overwritten.
Motivation
Mojo::UserAgent tls_option() is used to pass extra options to IO::Socket::SSL, but the code in Mojo::IOLoop::TLS unconditionally overwrites any SSL_verifycn_name the user is trying to pass.
References
As discussed on IRC.
I wanted to add a test case, but I cannot run the TEST_TLS tests. Being a very simple change, maybe a test is unneccessary.