Adding query and index time to options #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 28, 2015 17:53
|
I like the new options! More options are always good... Before I merge, could you:
If so, I'll merge in, and push out a new release. |
|
Hey. |
Looks a bit better now, but the tests are failing... You can see which ones on the Travis log; I'd imagine those also fail locally... Try running |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there
I was in the need of copying a portion of an index to another index for texting, while re indexing. therefore I've added such functionality to your awesome gem. Hope it suits all all needs xD.
I've also added scroll and query options to your implementations.
Please give some feedback!
Best regards!
Sérgio den Boer