-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Authentication Required and Proxy Authentication Required. #107
base: develop
Are you sure you want to change the base?
Conversation
@Karn Wanted to bring this PR to your attention. Someone else in the community opened it. Are you willing to have us merge this back into the main SippyCup repo? |
@Karn Would you let us know if you are willing to have your work merged into the upstream Sippy Cup code base? |
Hey @bklang, apologies for the late reply. We can totally look at merging this back upstream, give me a few days to clean up the code and get it into a reviewing state! |
933d72f
to
3ae18f5
Compare
2d0a579
to
3521f03
Compare
Adding 400 SIP message
Parameterizing sendrecv
I found this fork of Sippy Cup that adds these two very useful features. Authentation and Proxy Auth are difficult enough in sipp that (previously) I just gave up and didn't require authentication in my test infrastructure. This addition makes the auth effortless.
Auth becomes as simple as:
Proxy auth would mean using
s.proxy_auth_required
instead of
s.auth_required
This isn't my code, and I don't know why a pull request was ever created for this, but the only real potential problem as I see it is the method signature for adding a header is now an array, not a string to allow for multiple headers. If necessary to accept this merge request, it could be removed. The following commit is where it was added:
Enflick@6ae9db5