Skip to content
This repository was archived by the owner on Sep 29, 2025. It is now read-only.

Add gutter to column function, fix bad gutter accounting when using othe#38

Closed
marcorivm wants to merge 1 commit intomojotech:masterfrom
marcorivm:1c54e98bfbf07c176f5342d54ceffb17e8bfbfa1
Closed

Add gutter to column function, fix bad gutter accounting when using othe#38
marcorivm wants to merge 1 commit intomojotech:masterfrom
marcorivm:1c54e98bfbf07c176f5342d54ceffb17e8bfbfa1

Conversation

@marcorivm
Copy link
Copy Markdown
Contributor

...r than 1

Signed-off-by: Marco Rivadeneyra rockiano@gmail.com

…ther than 1

Signed-off-by: Marco Rivadeneyra <rockiano@gmail.com>
@ozamorowski
Copy link
Copy Markdown
Contributor

Oh, now I see :) Waiting for Cory to test this out. Btw, we'll need update docs, or at least mention this in the top comment.

@marcorivm
Copy link
Copy Markdown
Contributor Author

Why didn't you changed line 33 too?
width ( (100 - (g*2) * (number_of_nested_columns - 1)) / number_of_nested_columns )%
This is needed for the custom gutter to work, when using a set number of nested columns.

@corysimmons
Copy link
Copy Markdown
Contributor

I'm really, really, glad you're here Marco.

I made a test project, and updated it correctly, then went to add my changes to the repo and forgot. :)

Updated. Everything look good now?

@marcorivm
Copy link
Copy Markdown
Contributor Author

Yes, great!

@corysimmons
Copy link
Copy Markdown
Contributor

Awesome. Please check out #39 if you're interested in immortality. :)

@marcorivm
Copy link
Copy Markdown
Contributor Author

Not nearly sure on how to achieve that, but will put it in my todo list.

@corysimmons
Copy link
Copy Markdown
Contributor

It would make me extremely happy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants