Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard coded divisors #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

markbeazley
Copy link
Contributor

There are a few Sylius users who store their prices at a different prescicion to the Sylius default, and need to use a different divisor when converting to and from the int price value, to allow for easier overiding of this divisor the IntToStringConverter and DivisorProvider services should be used instead of hardcoding the value of 100, allowing stores that use a different divisor to only override 1 small class instead of quite a few different classes across the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant