-
Notifications
You must be signed in to change notification settings - Fork 0
maintenance and improvements #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
17a91c6 to
a07cad3
Compare
f27fdc2 to
51351c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is only a single small nit. Otherwise, it is LGTM.
| @@ -1,4 +1,4 @@ | |||
| **/tests/**/*.bcif | |||
| tests/*.bcif | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be BCIF files ignored altogether?
| - name: Publish to PyPI (production) | ||
| run: | | ||
| uv publish --trusted-publishing always |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make the publish work on adding a release tag instead? (same as molviewspec) I don't want a publish on each commit to main.
No description provided.