Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't do cgaz updates on modes that aren't defrag #106

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

jason-e
Copy link
Member

@jason-e jason-e commented Oct 15, 2023

I recently fixed some ConVar access debugging stuff and saw that cgaz's onUpdate is always running, even when not on the Defrag gamemode. Let me know if there's a more correct way to fix this.

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

Copy link
Member

@PeenScreeker PeenScreeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for Handling this

@tsa96 tsa96 merged commit 31fda5f into master Oct 15, 2023
1 check passed
@tsa96 tsa96 deleted the fix/disable-cgaz-non-df branch October 15, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants