Skip to content

Update Panorama panel and event names#112

Merged
TEKN1SHUN merged 3 commits intomomentum-mod:masterfrom
JJL772:refactor/panorama-names
Jan 19, 2024
Merged

Update Panorama panel and event names#112
TEKN1SHUN merged 3 commits intomomentum-mod:masterfrom
JJL772:refactor/panorama-names

Conversation

@JJL772
Copy link
Copy Markdown
Member

@JJL772 JJL772 commented Jan 17, 2024

Update panel/event names for the Panorama naming refactor. Bulky PR, but no functional changes were made.

This will probably cause some disruptions with pending PRs, although rebasing should be straightforward.

Do not merge until the internal PR is merged.

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below N/A

@JJL772 JJL772 force-pushed the refactor/panorama-names branch from a2ed126 to 074aa73 Compare January 17, 2024 08:05
@JJL772 JJL772 force-pushed the refactor/panorama-names branch from 0150a6e to 074aa73 Compare January 18, 2024 02:22
@JJL772
Copy link
Copy Markdown
Member Author

JJL772 commented Jan 18, 2024

Ok, this should be good to merge now. I have merged the internal PR, so this will need to go in before the next momentum update.

@JJL772 JJL772 force-pushed the refactor/panorama-names branch from a4c4213 to 35a2475 Compare January 18, 2024 02:25
@TEKN1SHUN TEKN1SHUN merged commit 6d4b087 into momentum-mod:master Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants