Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate Vector type definition #114

Closed
wants to merge 1 commit into from

Conversation

PeenScreeker
Copy link
Member

@PeenScreeker PeenScreeker commented Jan 19, 2024

This pull request fixes a potential problem with a duplicate type definition that was created with math.ts. The offending type has been renamed form Vector to VecXY to reflect the difference between the two types. VecXY is an object with properties named x, y, and sometimes z, while the Vector type is for number arrays with up to three elements.

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

@PeenScreeker PeenScreeker self-assigned this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant