refactor: Misc fixes for API model updates #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
JS looks fine besides not having autoformatting applied. CI should be yelling at you but the job is only configured to run on one branch. My last PR enables CI everywhere, then #127 brings the 0.10 branch up to date with that, please could you approve and merge that, then rebase this branch onto top of latest 0.10. Then run I'll double check this when more awake tomorrow and have reviewed the red side of this stuff |
Panzerhandschuh
force-pushed
the
feat/misc-map-model-fixes
branch
from
13c9cda
to
7db0c1d
Compare
tsa96
force-pushed
the
feat/misc-map-model-fixes
branch
from
7db0c1d
to
65fba01
Compare
tsa96
requested changes
Apr 7, 2024
Panzerhandschuh
force-pushed
the
feat/misc-map-model-fixes
branch
from
65fba01
to
9670266
Compare
tsa96
force-pushed
the
feat/misc-map-model-fixes
branch
from
f342ff8
to
65fba01
Compare
Panzerhandschuh
force-pushed
the
feat/misc-map-model-fixes
branch
from
65fba01
to
292f2b6
Compare
tsa96
force-pushed
the
feat/misc-map-model-fixes
branch
from
292f2b6
to
65fba01
Compare
tsa96
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UserMapDatafor checking if the map file exists or is in favorites