Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RegisterEventForGamemode util function #128

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

tsa96
Copy link
Member

@tsa96 tsa96 commented Apr 8, 2024

Function we discussed yesterday that both Mac and Peen are using atm, so figured it's best I get this PRed ASAP.

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

@tsa96 tsa96 requested a review from PeenScreeker April 8, 2024 10:34
@tsa96 tsa96 force-pushed the feat/RegisterEventForGamemode branch from a7392e1 to be6d841 Compare April 8, 2024 10:35
Copy link
Member

@PeenScreeker PeenScreeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great way to ensure mode-specific panels are only calculating things when the right mode is being played. Thanks!

@PeenScreeker PeenScreeker merged commit 0cd3d1c into master Apr 8, 2024
1 check passed
@PeenScreeker PeenScreeker deleted the feat/RegisterEventForGamemode branch April 8, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants