Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convar togglebuttons and two-click styling #142

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

PeenScreeker
Copy link
Member

@PeenScreeker PeenScreeker commented Aug 23, 2024

This pull request updates tabmenu and zoning UI to use new ToggleButton behavior. These menus no longer rely on GameInterfaceAPI.ConsoleCommand() or GameInterfaceAPI.SetSettingBool().

Before removing draft tag, I'm looking for feedback on which icon to use for signifying that two-click mode is disabled. See discussion in #Zoning UI in momentum discord.

Depends on red panorama changes. Red changes merged.

Checks

  • I have thoroughly tested all of the code I have modified/added/removed to ensure something else did not break
  • I have followed semantic commit messages e.g. feat: Add foo, chore: Update bar, etc...
  • My branch has a clear history of changes that can be easy to follow when being reviewed commit-by-commit
  • My branch is functionally complete; the only changes to be done will be those potentially requested in code review
  • All changes requested in review have been fixuped into my original commits.
  • Fully tokenized all my strings (no hardcoded English strings!!) and supplied bulk JSON strings below

POEditor JSON Strings (if needed)

[
	{
		"term": "Zoning_TwoClickTogle_Tooltip",
		"definition": "Toggle two-click point mode"
	}
]

@PeenScreeker PeenScreeker marked this pull request as ready for review August 25, 2024 21:23
@tsa96 tsa96 merged commit 1562471 into feat/mom-0.10 Aug 27, 2024
1 check passed
@tsa96 tsa96 deleted the feat/two-click-zoning branch August 27, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants