Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Status information for new timer #144

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Status information for new timer #144

merged 1 commit into from
Aug 26, 2024

Conversation

Panzerhandschuh
Copy link
Member

  • Display current run time
  • Timer states (disabled, prime, running, finished)
  • Track progress (current bonus, stage, checkpoint)
  • Timer sounds (start, stop, finish)

Comparisons still need to be implemented.

@Panzerhandschuh Panzerhandschuh changed the title Implemented status information for new timer Status information for new timer Aug 26, 2024
PeenScreeker
PeenScreeker approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@PeenScreeker PeenScreeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

tsa96
tsa96 requested changes Aug 26, 2024
View reviewed changes
Copy link
Member

@tsa96 tsa96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we be merging this into the 0.10.0 branch?

scripts/hud/timer.js Outdated Show resolved Hide resolved
@Panzerhandschuh Panzerhandschuh changed the base branch from master to feat/mom-0.10 August 26, 2024 17:59
@Panzerhandschuh Panzerhandschuh force-pushed the feat/new-timer-3 branch 2 times, most recently from aa0d0cc to a50f67e Compare August 26, 2024 18:39
@tsa96 tsa96 merged commit 31b127e into feat/mom-0.10 Aug 26, 2024
1 check passed
@tsa96 tsa96 deleted the feat/new-timer-3 branch August 26, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsa96 tsa96 tsa96 approved these changes

@PeenScreeker PeenScreeker PeenScreeker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Panzerhandschuh @tsa96 @PeenScreeker